[Webkit-unassigned] [Bug 32189] [GTK] Integrate running of API tests into buildbot run

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 19 14:50:52 PST 2010


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
  Attachment #44353|review?                     |review-
               Flag|                            |

--- Comment #2 from Eric Seidel <eric at webkit.org>  2010-01-19 14:50:51 PST ---
(From update of attachment 44353)
We have shared code for how to get the configuration directory in
webkitdirs.pm.  I think we should re-use that here.  Meaning we should just
make run-gtk-tests a perl script.  Unfortunately we don't have any equivalent
detection code for python or I would suggest we write this in python instead.

In general the code looks OK.  I'm not really an expert on the internals of
buildbot.  There might be a more concise way to write parts of the class.

No need to call bash directly, or?
+    command = ["bash", "./WebKitTools/Scripts/run-gtk-tests",

r- for not re-using existing configuration directory detection logic.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list