[Webkit-unassigned] [Bug 33864] REGRESSION: Infinite recursion in Position::getInlineBoxAndOffset()

Tue Jan 19 14:10:13 PST 2010

https://bugs.webkit.org/show_bug.cgi?id=33864

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46951|review?                     |review+
               Flag|                            |

--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com>  2010-01-19 14:10:13 PST ---
(From update of attachment 46951)
> Index: WebCore/ChangeLog
> ===================================================================

> +        REGRESSION: Infinite recursion in Position::getInlineBoxAndOffset()
> +        https://bugs.webkit.org/show_bug.cgi?id=33864
> +        <rdar://problem/7552959>
> +        
> +        Regression has been introduced by changeset 53085.
> +        The original fix had to be limited to editable content.

Could you reword this to explain it without reference to the original change?

> Index: LayoutTests/editing/selection/selection-applet.html
> ===================================================================
> --- LayoutTests/editing/selection/selection-applet.html	(revision 0)
> +++ LayoutTests/editing/selection/selection-applet.html	(revision 0)
> @@ -0,0 +1,10 @@
> +<body>
> +<script language="JavaScript" type="text/javascript">
> +if (window.layoutTestController)
> +     layoutTestController.dumpAsText();
> +
> +document.write('<applet id="test" width="400" height="400" name="test applet" code="test.class" codebase="." mayscript>');
> +document.write('You need Java(tm) to view this presentation. <a href="http://www.java.com">Download Java</a></applet> ');
> +window.getSelection().setPosition(document.getElementById("test"), 0);
> +</script>
> +</body>

Does the testcase really require Java, or would a simpler test with divs
suffice? Also, is it required to document.write the test content?

r=me, but it would be nice to make the testcase more generic if possible.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.