[Webkit-unassigned] [Bug 32196] [Qt] createPlugin() should decide whether Qt Plugins can be created when pluginsEnabled is false

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32196





--- Comment #11 from Jakub Wieczorek <faw217 at gmail.com>  2010-01-19 12:52:41 PST ---
While I'm here, my suggestions with regard to patch:

> +bool MIMETypeRegistry::isNativePluginMIMEType(const String& mimeType)
> +{
> +    UNUSED_PARAM(mimeType);
> +    return false;
> +}

I believe UNUSED_PARAM is supposed to only be used in C code. In C++ you can
omit the parameter name in the signature.

> index 0000000..05afae4
> --- /dev/null
> +++ b/LayoutTests/platform/qt/plugins/native-plugin-plugins-disabled-expected.txt
> @@ -0,0 +1,20 @@
> +layer at (0,0) size 800x600
> +  RenderView at (0,0) size 800x600
> +layer at (0,0) size 800x600
> +  RenderBlock {HTML} at (0,0) size 800x600
> +    RenderBody {BODY} at (8,8) size 784x584
> +      RenderBlock {DIV} at (0,0) size 784x34
> +        RenderText {#text} at (0,14) size 80x20
> +          text run at (0,14) width 80: "QT Plugin: "
> +        RenderPartObject {OBJECT} at (80,0) size 300x30 [QT: geometry: {at (88,8) size 300x30} isHidden: 0 isSelfVisible: 1 isParentVisible: 1 mask: {at (0,0) size 300x30} ] 
> +        RenderText {#text} at (0,0) size 0x0
> +      RenderBlock {DIV} at (0,34) size 784x34
> +        RenderText {#text} at (0,14) size 133x20
> +          text run at (0,14) width 133: "QT Styled Widget: "
> +        RenderPartObject {OBJECT} at (133,0) size 300x30 [QT: geometry: {at (0,0) size 300x30} isHidden: 1 isSelfVisible: 1 isParentVisible: 1 mask: {at (0,0) size 0x0} ] 
> +        RenderText {#text} at (0,0) size 0x0
> +      RenderBlock {DIV} at (0,68) size 784x104
> +        RenderText {#text} at (0,84) size 133x20
> +          text run at (0,84) width 133: "Third-party plugin: "
> +        RenderPartObject {EMBED} at (133,0) size 100x100
> +        RenderText {#text} at (0,0) size 0x0

I am not entirely sure but I think it should be possible to write a text-only
test, which somehow makes use of the JSC<->QObject bindings. Like reading some
properties or calling some slot?

> +    // Check to see if a mime type is a native plugin implemented by the
> +    // client (e.g. a QT Plugin).
> +    static bool isNativePluginMIMEType(const String& mimeType);
> +

> +<!-- qt plugin widget: will be created -->
> +<div>
> +QT Plugin:
> +<object type="application/x-qt-plugin" classid="QProgressBar" name="progressbar1" height=30></object>
> +</div>

QT -> Qt. :) This can be especially confusing for people more familliar with
QuickTime.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.