[Webkit-unassigned] [Bug 33403] [OpenVG] Add (EGL) surface/context management

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33403


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46930|review?                     |review+
               Flag|                            |




--- Comment #16 from Nikolas Zimmermann <zimmermann at kde.org>  2010-01-19 12:02:32 PST ---
(From update of attachment 46930)
Looks great, some small style fixes remaining, please fix before landing:


> +        static const EGLint configAttribs[] = {
> +            EGL_RED_SIZE, 8,
....
> +            EGL_NONE };

The }; needs to go in another line, aligned with the "static const" prefix.
There are several places in the patch that need to be fixed.


> +    WTF::HashMap<EGLSurface, SurfaceOpenVG*> m_platformSurfaces;
> +    WTF::HashMap<EGLNativeWindowType, EGLSurface> m_windowSurfaces;
> +    WTF::HashMap<EGLSurface, EGLint> m_surfaceConfigIds;
> +    WTF::HashMap<EGLint, EGLint> m_compatibleConfigIds;
> +    WTF::HashMap<EGLint, EGLContext> m_contexts;

Remove WTF:: prefixes. HashMap uses "using WTF::HashMap", so it's available in
all namespaces.
Thanks for the patience... r=me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.