[Webkit-unassigned] [Bug 30883] [Gtk] Implement AtkText for HTML elements which contain text

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 19 10:48:30 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=30883





--- Comment #32 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-01-19 10:48:29 PST ---
Attachment 46926 did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:912: 
webkit_accessible_text_get_text is incorrectly named. Don't use underscores in
your identifier names.  [readability/naming] [4]
WebKit/gtk/tests/testatk.c:367:  Declaration has space between * and variable
name in WebKitWebView* webView  [whitespace/declaration] [3]
WebKit/gtk/tests/testatk.c:368:  Declaration has space between * and variable
name in AtkObject* obj  [whitespace/declaration] [3]
WebKit/gtk/tests/testatk.c:369:  Declaration has space between * and variable
name in AtkObject* obj1  [whitespace/declaration] [3]
WebKit/gtk/tests/testatk.c:370:  Declaration has space between * and variable
name in AtkObject* obj2  [whitespace/declaration] [3]
WebKit/gtk/tests/testatk.c:371:  Declaration has space between * and variable
name in GMainLoop* loop  [whitespace/declaration] [3]
WebKit/gtk/tests/testatk.c:372:  Declaration has space between * and variable
name in AtkText* textObj1  [whitespace/declaration] [3]
WebKit/gtk/tests/testatk.c:373:  Declaration has space between * and variable
name in AtkText* textObj2  [whitespace/declaration] [3]
WebKit/gtk/tests/testatk.c:411:  Declaration has space between * and variable
name in WebKitWebView* webView  [whitespace/declaration] [3]
WebKit/gtk/tests/testatk.c:412:  Declaration has space between * and variable
name in AtkObject* obj  [whitespace/declaration] [3]
WebKit/gtk/tests/testatk.c:413:  Declaration has space between * and variable
name in AtkObject* obj1  [whitespace/declaration] [3]
WebKit/gtk/tests/testatk.c:414:  Declaration has space between * and variable
name in AtkObject* obj2  [whitespace/declaration] [3]
WebKit/gtk/tests/testatk.c:415:  Declaration has space between * and variable
name in GMainLoop* loop  [whitespace/declaration] [3]
WebKit/gtk/tests/testatk.c:416:  Declaration has space between * and variable
name in AtkText* textObj1  [whitespace/declaration] [3]
WebKit/gtk/tests/testatk.c:417:  Declaration has space between * and variable
name in AtkText* textObj2  [whitespace/declaration] [3]
Total errors found: 15


If any of these errors are false positives, please file a bug against
check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list