[Webkit-unassigned] [Bug 32169] Implement TextCodec for WINCE port

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 19 10:38:22 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=32169


Patrick R. Gansterer <paroga at paroga.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46925|                            |review?
               Flag|                            |




--- Comment #7 from Patrick R. Gansterer <paroga at paroga.com>  2010-01-19 10:38:20 PST ---
Created an attachment (id=46925)
 --> (https://bugs.webkit.org/attachment.cgi?id=46925)
The patch (additonal style issues fixed)

(In reply to comment #5)
> Why isn't this method declared in a header?  Is it defined in
> WebCore/platform/graphics/wince/FontCacheWince.cpp.  If it's a utility method,
> I think it should be moved to its own header and source file.
Where is the best place for this method? Isn't it better to add it as static
function in TextCodec or FontCache?

> Why is receive() a pure virtual function?  It's implementation doesn't seem
> optional in enumerateSupportedEncodings().
What is wrong with an abstract class at this place?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list