[Webkit-unassigned] [Bug 33783] [DRT][Mac] Add modifiers parameter to mouseDown() and mouseUp()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33783


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46876|review?                     |review+
               Flag|                            |




--- Comment #5 from Darin Adler <darin at apple.com>  2010-01-19 08:26:35 PST ---
(From update of attachment 46876)
Looks fine.

r=me

Not directly related to this patch: I realize now that the use of
performSelector:withObject: is already wrong for mouseDown: and mouseUp: since
they have an argument that is not an object. Someone should clean this up in
the future. I think we can just replace mouseDown: and mouseUp: with
mouseDownButton0 and mouseUpButton0 methods that don't take arguments at all.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.