[Webkit-unassigned] [Bug 33829] Web Inspector: Timeline panel's reset button problem

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33829


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46897|review?                     |review-
               Flag|                            |




--- Comment #2 from Pavel Feldman <pfeldman at chromium.org>  2010-01-19 02:39:00 PST ---
(From update of attachment 46897)
> +        if (recordsInWindow.length > startIndex) 
> +            while (startIndex > 0 &&  recordsInWindow[startIndex].parent)
> +                startIndex--;
> +        else 
> +            startIndex = recordsInWindow.length ? recordsInWindow.length - 1 : 0;
> +

I think that what has been happening here was fundamentally wrong. It probably
regressed when I introduced expansion/collapsing. Row offset can no longer be
calculated as number of record * row height. We now need to take expanded state
into consideration.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.