[Webkit-unassigned] [Bug 33266] WebCore::InlineFlowBox::determineSpacingForFlowBoxes ReadAV at NULL (43c64e8abbda6766e5f5edbd254c2d57)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 19 02:29:07 PST 2010


Roland Steiner <rolandsteiner at chromium.org> changed:

           What    |Removed                     |Added
  Attachment #46665|0                           |1
        is obsolete|                            |
  Attachment #46898|                            |review?
               Flag|                            |

--- Comment #8 from Roland Steiner <rolandsteiner at chromium.org>  2010-01-19 02:29:06 PST ---
Created an attachment (id=46898)
 --> (https://bugs.webkit.org/attachment.cgi?id=46898)
patch - addressing the review remarks

Changed the patch as requested, in particular:

-) Changed moveAllChildrenTo() to use original coding with 2 variables. I don't
think there'd be any speed difference, but then again safe is safe... ;)

-) Renamed methods as suggested, refactored moveInlineChildren() as suggested

-) Changed method signatures to use RenderRubyBase* instead of the more generic
RenderBlock*. This should also address the question about
createsAnonymousWrapper (?).

-) about braces around a single line clause: ISTR there was a discussion on
webkit-dev@ that that's ok if it's consistent between the if and the else
clause (?). But I'm not religious about such things, so I removed them anyway.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list