[Webkit-unassigned] [Bug 33822] New: REGRESSION(r53273): TransformationMatrix.h needs to include <windows.h> for XFORM.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33822

           Summary: REGRESSION(r53273): TransformationMatrix.h needs to
                    include <windows.h> for XFORM.
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: Blocker
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: dbates at webkit.org
                CC: sfalken at apple.com


Changeset 53273 <http://trac.webkit.org/changeset/53273> broke the Qt Windows
build when using the MinGW compiler.

In particular, we cannot typedef/forward-declare XFORM in
TransformationMatrix.h because this causes a redefinition error with the struct
of the same name defined in C:\Qt\2009.05\mingw\include\wingdi.h. Also, the
MinGW wingdi.h does not define the macro definition _XFORM_ (like in the
Microsoft SDK), so we cannot determine whether this struct is already defined
using the preprocessor.

For completeness, the following is a snippet from the build output including
the error message:

.\..\JavaScriptCore\pcre" [...] -o obj\debug\SVGElementFactory.o generated\SVG
ElementFactory.cpp
In file included from ..\..\..\WebCore\svg/SVGTransform.h:25,
                 from ..\..\..\WebCore\svg/SVGTransformList.h:26,
                 from ..\..\..\WebCore\svg/SVGTransformable.h:27,
                 from ..\..\..\WebCore\svg/SVGStyledTransformableElement.h:27,
                 from ..\..\..\WebCore\svg/SVGAElement.h:28,
                 from generated\SVGElementFactory.cpp:34:
..\..\..\WebCore\platform\graphics\transforms/TransformationMatrix.h:47: error:
conflicting declaration 'typedef struct tagXFORM XFORM'
c:\qt\2009.05\mingw\bin\../lib/gcc/mingw32/4.4.0/../../../../include/wingdi.h:16
34: error: 'XFORM' has a previous declaration as 'typedef struct _XFORM XFORM'
make[2]: *** [obj/debug/SVGElementFactory.o] Error 1

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.