[Webkit-unassigned] [Bug 33769] [Chromium] layout_test on linux fails on doubleclick-beside-cr-span.html

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33769





--- Comment #5 from MORITA Hajime <morrita at gmail.com>  2010-01-18 18:02:37 PST ---
Thank you for reviewing!
I updated the patch.

> It would be better to explain how did you fix this failure.
Added an explanation.

> I'd say "Out test cases will have at most a single leading tab followed by a
> word whose length is more than 4. So, pos.x + CHAR_WIDTH * 4 always hits the
> words" or something.
Fixed. Thank you to clarify.

> 
> I think we usually put white-spaces around '*' and '/'.
Fixed.

> I'm not sure why this "Here" is necessary. I think it would be nice if you put
> a comment for this line.
> 
(snip)
> 
> Why did we change here?
Added an explanation in the comment

> 
> > -abcd efgh ijkl mnop<b id="totest_multiple_whitespaces_in_pre">    select6    </b>nottoselect
> > +abcd efgh ijkl mnop<b id="totest_multiple_whitespaces_in_pre">   select6   </b>nottoselect
> 
Removed.
At first, clarifying whitespace length limitation by doing this looked good
idea,
but it isn't...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.