[Webkit-unassigned] [Bug 33806] Would like API to disallow setting of document.domain for pages with certain URL schemes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33806





--- Comment #6 from Adam Roben (aroben) <aroben at apple.com>  2010-01-18 14:39:35 PST ---
(In reply to comment #5)
> + if
> (SecurityOrigin::isDomainRelaxationForbiddenForURLScheme(securityOrigin()->protocol()))
> {
> 
> That line looks overly convoluted.  Why not just
> 
> if (securityOrigin()->canSetDomainFromDOM()) {
> 
> ?

That seems OK to me. isDomainRelaxationForbiddenForURLScheme seemed more
symmetric with setDomainRelaxationForbiddenForURLScheme, which is why I did it
this way. Also, adding canSetDomainFromDOM() seems strange when all the other
"can set" checks are in Document::setDomain.

But if you really think it would be better, I'm happy to change it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.