[Webkit-unassigned] [Bug 33245] Second right floated image misplacment

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33245


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46837|review?                     |review+
               Flag|                            |




--- Comment #12 from Darin Adler <darin at apple.com>  2010-01-18 12:44:30 PST ---
(From update of attachment 46837)
Neither the change log nor the source files explain the role of this additional
box. I think you need a one-sentence comment stating what, to you, is obvious.

> +    TrailingFloatsRootInlineBox(RenderObject* obj) : RootInlineBox(obj)

I would call this "object", not "obj".

> +    virtual int virtualHeight() const { return 0; }

I would make this member function private. It would be a programming error to
call this with a TrailingFloatsRootInlineBox*.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.