[Webkit-unassigned] [Bug 33803] Web Inspector: PanelEnablerView._windowResized is slow, called even when the view is hidden

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33803


Timothy Hatcher <timothy at hatcher.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46833|1                           |0
        is obsolete|                            |




--- Comment #4 from Timothy Hatcher <timothy at hatcher.name>  2010-01-18 10:57:27 PST ---
(From update of attachment 46833)

>      resize: function()
>      {
>          this.updateGraphDividersIfNeeded();
> +        WebInspector.Panel.prototype.resize.call(this);
>      },

We should call the prototype first if there isn't a good reason to call it
last. And I like to seperate them by a blank line to distinguish it.


>          this.updateSidebarWidth();
> +
> +        if (this._delayedResize) {
> +            this._delayedResize = false;
> +            this.resize();
> +        }

There isn't a need for the _delayedResize code, since resize is only called on
the currentPanel. And updateSidebarWidth does a resize.

>          this.updateMainViewWidth(width);
>
> -        var visibleView = this.visibleView;
> -        if (visibleView && "resize" in visibleView)
> -            visibleView.resize();
> +        WebInspector.Panel.prototype.resize.call(this);

I think we should add the visibleView resize code to updateMainViewWidth, and
just make Panel.prototype.resize call updateMainViewWidth.

Then this code wouldn't be needed, since updateMainViewWidth is called right
before it.

We want subclasses of updateMainViewWidth to call the Panel prototype then.


> +    resize: function()
> +    {
> +        if (!this.visible) {
> +            this._delayedResize = true;
> +            return;
> +        }

I don't think the delayed resize code is needed.


Is the Welcome view and Enabler view the visibleView? Where is that handled? I
don't think it is. The visibleView is only used by the data views.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.