[Webkit-unassigned] [Bug 33783] [DRT][Mac] Add modifiers parameter to mouseDown() and mouseUp()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33783


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46790|review?                     |review-
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2010-01-18 10:49:08 PST ---
(From update of attachment 46790)
> -    [self performSelector:@selector(mouseDown:) withObject:nil afterDelay:0];
> -    [self performSelector:@selector(mouseUp:) withObject:nil afterDelay:0];
> +    [self performSelector:@selector(mouseDown:withModifiers:) withObject:nil afterDelay:0];
> +    [self performSelector:@selector(mouseUp:withModifiers:) withObject:nil afterDelay:0];

This isn't reliable. The argument to "withModifiers" will be random data on the
stack. The object "nil" is passed as the first argument, but no second argument
is passed. The simplest way I can think of to make this work is to keep a
method with the old name and have it call the new method. There may be other
alternatives.

review- because of this

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.