[Webkit-unassigned] [Bug 33794] Web Inspector: Speed-up Timeline panel scrolling (second iteration).

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33794


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46814|review?                     |review-
               Flag|                            |




--- Comment #2 from Pavel Feldman <pfeldman at chromium.org>  2010-01-18 06:31:17 PST ---
(From update of attachment 46814)
> +    this._graphRows = document.createElement("div");

We typically call elements someElement. Maybe kill it?

> -        var start = (record.startTime - this.minimumBoundary) / this.boundarySpan * 100;
> -        var end = (record.endTime - this.minimumBoundary) / this.boundarySpan * 100;
> +        var start = (record.startTime - this._context.minB) / this._context.bSpan * 100;

this._context.minimumBoundary. Btw, this calculator is supposed to cache min
and max boundaries, so it is not clear why you are gaining some win out of it.
Maybe cache is broken? Or typeof ... === "number" works slowly? Should we try
using -1 as an uninitialized value then?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.