[Webkit-unassigned] [Bug 33453] [Qt] MediaPlayerPrivate: expose supported types to WebCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33453


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46246|review?                     |review-
               Flag|                            |




--- Comment #9 from Simon Hausmann <hausmann at webkit.org>  2010-01-16 01:04:35 PST ---
(From update of attachment 46246)

In general this patch looks good to me! I'm only nitpicking a bit :)

> +static HashSet<String>* supportedTypes = 0;

Shouldn't this be a global static object, so that the has is freed?

> +
>  MediaPlayerPrivate::MediaPlayerPrivate(MediaPlayer* player)
>      : m_player(player)
>      , m_networkState(MediaPlayer::Empty)
> @@ -145,15 +149,64 @@ MediaPlayerPrivate::~MediaPlayerPrivate()
>      m_mediaObject = 0;
>  }
>  
> -void MediaPlayerPrivate::getSupportedTypes(HashSet<String>&)
> +void MediaPlayerPrivate::rebuildSupportedTypesCache()
>  {
> -    notImplemented();
> +    ASSERT(!supportedTypes);
> +    supportedTypes = new HashSet<String>;

Why is the function called _rebuild_SupportedTypesCache() when it can only
be called once? :) (Assert in debug build, leak in release build)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.