[Webkit-unassigned] [Bug 33724] New: check-webkit-style: Misses variables that contain underscores.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 15 10:54:03 PST 2010


           Summary: check-webkit-style: Misses variables that contain
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: dbates at webkit.org
                CC: eric at webkit.org, abarth at webkit.org,
                    hamaji at chromium.org

Notice, the file WebCore/rendering/style/SVGRenderStyle.h
contains various structs who field names contain an underscore.

Run check-webkit-style on file WebCore/rendering/style/SVGRenderStyle.h.

It catches NonInheritedFlags::_niflags and outputs the following error:

WebCore/rendering/style/SVGRenderStyle.h:167:  _niflags is incorrectly named.
Don't use underscores in your identifier names.  [readability/naming] [4]

But misses all the fields in InheritedFlags and the fields within the struct of
the union in NonInheritedFlags.

For example:

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list