[Webkit-unassigned] [Bug 33695] [Chromium] Adds EventSource bindings for V8

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33695





--- Comment #5 from Nate Chapin <japhet at chromium.org>  2010-01-15 09:20:25 PST ---
(From update of attachment 46626)
A couple of small nits...

In addition to the inline comments, I think you need to add the new files to
WebCore/Android.v8bindings.mk as well.

> Index: ChangeLog
> ===================================================================
> --- ChangeLog	(revision 53295)
> +++ ChangeLog	(working copy)
> @@ -1,3 +1,25 @@
> +2010-01-14  Marcus Bulach  <bulach at chromium.org>

Remove the garbage before the date.

> +        * ../../WebCore.gypi:
> +        * ../../bindings/scripts/CodeGeneratorV8.pm:
> +        * ../../bindings/v8/DOMObjectsInclude.h:
> +        * ../../bindings/v8/DerivedSourcesAllInOne.cpp:
> +        * ../../bindings/v8/V8DOMWrapper.cpp:
> +        * ../../bindings/v8/V8DOMWrapper.h:
> +        * ../../bindings/v8/V8Index.cpp:
> +        * ../../bindings/v8/V8Index.h:
> +        * ../../bindings/v8/WorkerContextExecutionProxy.cpp:
> +        * ../../bindings/v8/custom/V8CustomBinding.h:
> +        * ../../bindings/v8/custom/V8EventSourceConstructor.cpp: Added.
> +        * ../../bindings/v8/custom/V8EventSourceCustom.cpp: Added.

Remove the leading ../../

> +#if ENABLE(EVENTSOURCE)
> +    case V8ClassIndex::EVENTSOURCE: {
> +        descriptor->SetCallHandler(USE_CALLBACK(EventSourceConstructor));
> +        break;
> +    }
> +#endif

Add this block down with the other SetCallHandler() calls.

> + * Copyright 2009, The Android Open Source Project

Here and in V8EventSourceConstructor.cpp, 2010

> +using namespace std;
> +using namespace WTF;

I don't think these are necessary?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.