[Webkit-unassigned] [Bug 33689] WebSocket: Missing Request-URI, when no tralling slash in host

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33689


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46648|review?                     |review-
               Flag|                            |




--- Comment #3 from Alexey Proskuryakov <ap at webkit.org>  2010-01-15 08:47:22 PST ---
(From update of attachment 46648)
Code changes look good, but I think I'll ask to rework the test. It has
absolutely no reason to be script-tests-based - it doesn't have even a single
shouldBe anywhere! A bigger issue is that test output doesn't really mention
pass/fail criteria, and that it relies on assertions that may be gone at the
same time the bug is reintroduced.

A more reliable way to test this would be for the server to report invalid
requests in some manner (possibly by setting a state that can be retrieved
later, or maybe by intercepting these and forwarding to a specific handler
whose response we could check).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.