[Webkit-unassigned] [Bug 31470] [Gtk] For removing ICU, implement IDN support by means of libidn

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31470


Dominik Röttsches <dominik.roettsches at access-company.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #44621|0                           |1
        is obsolete|                            |
  Attachment #46657|                            |review?
               Flag|                            |




--- Comment #5 from Dominik Röttsches <dominik.roettsches at access-company.com>  2010-01-15 01:46:27 PST ---
Created an attachment (id=46657)
 --> (https://bugs.webkit.org/attachment.cgi?id=46657)
IDN support through libidn

(In reply to comment #4)
> (From update of attachment 44621 [details])

> A nitpick, but I guess retValue or something like that would be better than
> 'err', since the variable does not necessarily denote an error.
> [...]
> I very much prefer to rely on pkg-config for this, as we do everywhere else.

Comments addressed.

> Also, is there any chance this could be folded into glib at some point?
> Depending on a new library for a single function is kind of silly.

I agree - but don't know about such plans. I could file it as an issue for
glib.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.