[Webkit-unassigned] [Bug 22725] Make SQL database storage work in Workers

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 14 17:58:41 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=22725





--- Comment #20 from Andrew Wilson <atwilson at chromium.org>  2010-01-14 17:58:39 PST ---
(From update of attachment 46403)
The worker shutdown behavior is somewhat subtle and has been a source of
hard-to-track race conditions in the past, but I think you're doing the right
things. The thing I'd want to be careful about is making sure no more events
sneak in after the thread has been stopped (since we're now doing a couple of
queue flushes before shutting down the message loop and exiting the thread),
but it looks like the code you added to WorkerRunLoop *should* do that. Run the
worker layout tests in a loop for an hour to shake out any new race conditions
:)

> +
> +        m_runLoop.postTask(WorkerThreadShutdownStartTask::create());
> +    } else
> +        m_runLoop.terminate();
>  }
>  
>  } // namespace WebCore

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list