[Webkit-unassigned] [Bug 33691] Drag and Drop source/destination code needs cleanup

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33691





--- Comment #4 from Adam Roben (aroben) <aroben at apple.com>  2010-01-14 15:16:13 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 46611 [details] [details])
> > Is it really OK to make this change? Will we break websites that call
> > preventDefault() but don't set dropEffect?
> 
> That code will never be hit after r53287, because destinationOperation will
> never return false.

Ah, OK, so we've already made this change. You're just removing dead code now.

> This makes it compliant with the spec, but I haven't found
> any demos. I did have to make changes to some of our layout tests, that was why
> I had to roll out the change and roll it back in. I feel like being more
> compliant with the spec is important, but if there are a lot of websites that
> use drag and drop, then I could drop this change, and make some changes to
> r53287.

We should try to find sites that rely on the old behavior. It might be useful
to find out what sites were used to reverse-engineer IE's implementation in
order to write WebKit's.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.