[Webkit-unassigned] [Bug 33096] [Qt] DRT: Support evaluateInWebInspector(), setTimerProfilingEnabled() and display().

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 14 13:04:03 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=33096





--- Comment #25 from Robert Hogan <robert at roberthogan.net>  2010-01-14 13:04:01 PST ---
(In reply to comment #24)
> (In reply to comment #21)
> > Attachment 46592 [details] [details] did not build on qt:
> > Build output: http://webkit-commit-queue.appspot.com/results/187578
> 
> Robert, you missed the closing '}' of
> LayoutTestController::setUserStyleSheetEnabled(). Aside of this minor error,
> the build and layout test finished.
> 
> I got only one failing test which should be skipped and file a bug on it:
> --- /tmp/layout-test-results/inspector/timeline-paint-expected.txt   
> 2010-01-14 12:33:10.000000000 -0800
> +++ /tmp/layout-test-results/inspector/timeline-paint-actual.txt    2010-01-14
> 12:33:10.000000000 -0800
> @@ -1,14 +1,3 @@
>  Tests the Timeline API instrumentation of a paint event
> 
> -Paint Properties:
> -+ startTime : * DEFINED *
> -+ data : {
> -+- x : 0
> -+- y : 0
> -+- width : * DEFINED *
> -+- height : * DEFINED *
> -+ }
> -+ children : * DEFINED *
> -+ endTime : * DEFINED *
> -+ type : 3
> 

I had exactly that behaviour (intermittently) in previous patches. However with
the version for review it has passed for me without fail. It is the same test
that displays the webview as you describe below - the test relies on timelining
a paint event so displaying the window is necessary. Why is displaying the
window a problem?

> Unfortunately I got a nasty feature of this patch. Regularly a new window is
> appeared and then it is disappeared. Could you solve it? I think it is a minor
> request that we can fix later. (after land) As far as I remember András fixed a
> similar window appearing problem previously. András, could you help us?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list