[Webkit-unassigned] [Bug 19268] Profiles panel should make recording the first profile more obvious

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 14 10:42:18 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=19268


Timothy Hatcher <timothy at hatcher.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46581|review?                     |review-
               Flag|                            |




--- Comment #7 from Timothy Hatcher <timothy at hatcher.name>  2010-01-14 10:42:18 PST ---
(From update of attachment 46581)

> +            function messageButtonClicked()
> +            {
> +                profileType.buttonClicked.call(profileType);
> +            }

This does not need to use .call(). You can also just use
profileType.buttonClicked.bind(profileType) and pass it to addEventListener.

Fix that and I'll r+.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list