[Webkit-unassigned] [Bug 19268] Profiles panel should make recording the first profile more obvious

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=19268


Timothy Hatcher <timothy at hatcher.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46573|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #5 from Timothy Hatcher <timothy at hatcher.name>  2010-01-14 08:54:19 PST ---
(From update of attachment 46573)

> +++ b/WebCore/inspector/front-end/ProfilesWelcomeView.js

I think this should not be specific to Profiles panel, and should be generic
for use by other Panels.


> +    registerProfileType: function(profileType)

This can be generalized to take just an HTML message, then it isn't Profiles
specific.


> +        } else {
> +            messageElement.innerHTML = message;
> +        }

No braces here.


> +.panel-enabler-view.profiles.welcome {
> +.panel-enabler-view.profiles.welcome img {
> +.panel-enabler-view.profiles.welcome .instructions {
> +.panel-enabler-view.profiles.welcome .profile-type-message {
> +.panel-enabler-view.welcome button {

These selectors don't need .profiles in them. They can be generic to all
welcome views.

I think this is fine as, but I would like to see it be more generic.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.