[Webkit-unassigned] [Bug 33614] [Qt] Missing fileSystemPath() method in Qt KURL implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33614


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46506|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #6 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-01-14 03:01:10 PST ---
(From update of attachment 46506)

>  
>  String KURL::fileSystemPath() const
>  {
> -    notImplemented();
> +    if (m_string.isEmpty())
> +        return String();
> +
> +#if QT_VERSION >= QT_VERSION_CHECK(4, 6, 0)
> +    QUrl url = QUrl::fromUserInput(m_string);

Why use this? This might change an invalid URL into a valid one. This doesn't
seem right and at least needs a comment

> +#else
> +    QUrl url = QUrl(m_string);
> +#endif
> +    if (url.isValid())
> +        return String(url.path());
> +
>      return String();
>  }
>

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.