[Webkit-unassigned] [Bug 23556] On RTL pages, horizontal scrollbar is missing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23556





--- Comment #25 from Hironori Bono <hbono at chromium.org>  2010-01-14 02:41:25 PST ---
Thank you for your comments and sorry for my slow response.
I have been reading the rendering code of WebKit to find better solutions for
this bug. (I noticed my change was not a good one and this was the reason why I
wasn't confident of it. ) This suggestion definitely helps it.

Regards,

Hironori Bono

(In reply to comment #24)
> (From update of attachment 45958 [details])
> This doesn’t look like the right approach to fixing this bug. There is no
> apparent reason why it should involve increasing the size of RenderBlock, and
> this seems to account only for block children of blocks in normal flow.
> Changing the margin like has all sorts of consequences, e.g. affecting computed
> style. I don’t understand why any of this is necessary unless the body element
> is RTL. Looking at what Firefox does, it seems to be the only consideration.
> This patch also doesn’t address the initial position of the horizontal
> scrollbar on a RTL page. It maintains a lot of asymmetry between the RTL and
> LTR cases.
> 
> I think the correct approach should be similar to a case that already behaves
> correctly: RTL blocks with overflow: scroll. The logic for those is in
> RenderLayer. They mirror the behavior of LTR blocks with overflow: scroll.
> RenderView should behave the same with respect to the direction of the body
> element. Currently it has a LTR bias: docWidth() considers the rightmost
> position and the right edges of child boxes. layout() adds overflow to the
> right but never to the left, etc.
>
> The correct place to fix this is mainly in RenderView, but some changes to
> FrameView and Frame will probably be needed too. I suggest studying the
> RenderLayer code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.