[Webkit-unassigned] [Bug 33619] Move more of the selection and caret painting code from Frame to SelectionController

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33619


mitz at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46488|review?                     |review+
               Flag|                            |




--- Comment #3 from mitz at webkit.org  2010-01-13 13:22:15 PST ---
(From update of attachment 46488)
> +        "layout" is usedfor other purposes in this function.

Typo: “usedfor”

> -    bool m_needsLayout : 1;       // true if the caret and expectedVisible rectangles need to be calculated
> +    bool m_needsLayout; // true if the caret and expectedVisible rectangles need to be calculated

I don’t know what expectedVisible is, in this comment that you’re moving.

r=me but this apparently breaks the Qt build:
<https://webkit-commit-queue.appspot.com/results/184631>.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.