[Webkit-unassigned] [Bug 33096] [Qt] DRT: Support evaluateInWebInspector(), setTimerProfilingEnabled() and display().

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33096





--- Comment #14 from Robert Hogan <robert at roberthogan.net>  2010-01-13 12:51:00 PST ---
(In reply to comment #11)
> Why is the call to showWebInspector() needed in the evaluateInWebInspector()
> implementation? I don't see this call in the implementation for other
> platforms. Is it because QtWebKit initializes the inspector more lazily than
> the other platforms? As it stands it looks like a bit of a hack.
> 
> Specifically I'm curious whether other platforms are also hitting the
> m_frontend == 0 case in InspectorController::evaluateForTestInFrontend() (which
> is what happens if one does not call showWebInspector() in the Qt port), or if
> there is actually a way to have it evaluate stuff without showing it.

Hi Kent - you've hit the nail on the head here. As well as being a hack, the
lazy init was causing a lot of flakiness when running the tests. Bypassing
QWebInspector for initializing and closing the controller has allowed the tests
to pass every time for me now.

There's also no need to actually display the inspector (as you suggested)
though there is still a need to display the webview for the timeline-paint.html
test.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.