[Webkit-unassigned] [Bug 32834] svn-apply should handle git patches with similarity index, rename and copy directives

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32834





--- Comment #2 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2010-01-13 08:36:20 PST ---
(In reply to comment #1)
> For the purpose of submitting Git patches, it seems there can be (at least) two
> approaches:
> 
> (1) Make a "create-patch" script that supports creating a patch in standard
> format from both SVN and Git.
> 
> (2) Make svn-apply and svn-unapply support both Git and SVN format.
> 
> (Combining both approaches may also make sense -- e.g. to address the
> issue in this bug report.)
> 
> From what I can tell, we currently do (2) to some extent, but not (1).  Has
> anyone given much thought to these approaches?  Are there any reasons to
> prefer (2) over (1) or vice versa, or to not do (1)?

I think (2) is a higher priority than (1) because git's own diff subcommand
(with the --binary switch) is sufficient to capture all of the changes in a
patch.

Because the project's source repository is subversion (with a moderate number
of developers using git), I think it's slightly more important that git patches
work with the tools to apply patches to an svn working directory than
vice-versa.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.