[Webkit-unassigned] [Bug 33590] [GTK] GObject DOM bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33590





--- Comment #7 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-01-13 06:44:38 PST ---
Attachment 46453 did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/bindings/gobject/webkitdomstringconvert.h:21:  #ifndef header guard has
wrong style, please use: webkitdomstringconvert_h  [build/header_guard] [5]
WebCore/bindings/gobject/webkitdomstringconvert.h:32: 
webkit_dom_gstring_convert is incorrectly named. Don't use underscores in your
identifier names.  [readability/naming] [4]
WebCore/bindings/gobject/webkitdomstringconvert.h:33: 
webkit_dom_gstring_convert is incorrectly named. Don't use underscores in your
identifier names.  [readability/naming] [4]
WebCore/bindings/gobject/webkitdomstringconvert.h:34: 
webkit_dom_gstring_convert is incorrectly named. Don't use underscores in your
identifier names.  [readability/naming] [4]
WebCore/bindings/gobject/webkitdomstringconvert.h:35: 
webkit_dom_gstring_convert is incorrectly named. Don't use underscores in your
identifier names.  [readability/naming] [4]
WebCore/bindings/gobject/WebKitDOMBinding.cpp:36:  Alphabetical sorting
problem.  [build/include_order] [4]
WebCore/bindings/gobject/WebKitDOMBinding.cpp:82:  A case label should not be
indented, but line up with its switch statement.  [whitespace/indent] [4]
WebCore/bindings/gobject/WebKitDOMObject.cpp:16:  webkit_dom_object_init is
incorrectly named. Don't use underscores in your identifier names. 
[readability/naming] [4]
WebCore/bindings/gobject/WebKitDOMObject.cpp:20:  webkit_dom_object_class_init
is incorrectly named. Don't use underscores in your identifier names. 
[readability/naming] [4]
WebCore/bindings/gobject/WebKitDOMBinding.h:29:  Alphabetical sorting problem. 
[build/include_order] [4]
WebCore/bindings/gobject/WebKitDOMBinding.h:37:  Code inside a namespace should
not be indented.  [whitespace/indent] [4]
WebCore/bindings/gobject/WebKitDOMObject.h:29:  Alphabetical sorting problem. 
[build/include_order] [4]
WebCore/bindings/gobject/WebKitDOMObject.h:44:  parent_instance is incorrectly
named. Don't use underscores in your identifier names.  [readability/naming]
[4]
WebCore/bindings/gobject/WebKitDOMObject.h:50:  parent_class is incorrectly
named. Don't use underscores in your identifier names.  [readability/naming]
[4]
WebCore/bindings/gobject/WebKitDOMObject.h:54:  Extra space before ( in
function call  [whitespace/parens] [4]
Total errors found: 15

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.