[Webkit-unassigned] [Bug 33578] New: webkit-patch land fails if a user provides a bug ID

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33578

           Summary: webkit-patch land fails if a user provides a bug ID
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: hamaji at chromium.org


webkit-patch land fails if a user doesn't provide a bug ID by command line
flags and ChangeLog doesn't contain the bug URL.

Traceback (most recent call last):
  File "./WebKitTools/Scripts/webkit-patch", line 108, in <module>
    WebKitPatch().main()
  File "/Users/hamaji/GitKit/WebKitTools/Scripts/webkitpy/multicommandtool.py",
line 299, in main
    return command.check_arguments_and_execute(options, args, self)
  File "/Users/hamaji/GitKit/WebKitTools/Scripts/webkitpy/multicommandtool.py",
line 113, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File
"/Users/hamaji/GitKit/WebKitTools/Scripts/webkitpy/commands/abstractsequencedcommand.py",
line 43, in execute
    self._sequence.run_and_handle_errors(tool, options,
self._prepare_state(options, args, tool))
  File "/Users/hamaji/GitKit/WebKitTools/Scripts/webkitpy/stepsequence.py",
line 66, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Users/hamaji/GitKit/WebKitTools/Scripts/webkitpy/stepsequence.py",
line 60, in _run
    step(tool, options).run(state)
  File
"/Users/hamaji/GitKit/WebKitTools/Scripts/webkitpy/steps/updatechangelogswithreviewer.py",
line 54, in run
    bug_id = state.get("bug_id") or state["patch"].bug_id()
KeyError: 'patch'

This is the line in question:

    bug_id = state.get("bug_id") or state["patch"].bug_id()

I'm not sure when state["patch"] can be set (I didn't understand the recent
changes on this tool yet). If this won't be set, we may be able to remove
expression after "or". Otherwise, we may want to do like

    bug_id = state.get("bug_id")
    if not bug_id and "patch" in state
        bug_id = state["patch"].bug_id()

?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.