[Webkit-unassigned] [Bug 33554] run-webkit-tests fails on Ruby 1.9

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 12 23:52:57 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=33554


Shinichiro Hamaji <hamaji at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46402|review?                     |review-
               Flag|                            |




--- Comment #2 from Shinichiro Hamaji <hamaji at chromium.org>  2010-01-12 23:52:57 PST ---
(From update of attachment 46402)
>          def self.parse(string)
>              haveSeenDiffHeader = false
> -            linesForDiffs = string.inject([]) do |diffChunks, line|
> +            diffChunks = linesForDiffs = []
> +            string.each_line do |line|
>                  if (PrettyPatch.diff_header?(line))
>                      diffChunks << []
>                      haveSeenDiffHeader = true

I think the local variable diffChunks isn't necessary anymore?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list