[Webkit-unassigned] [Bug 32390] WebCore::SplitElementCommand::SplitElementCommand ReadAV at NULL (3d3ebb81789addf3fcdd28c39a72b244)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32390


Tony Chang (Google) <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|webkit-unassigned at lists.web |tony at chromium.org
                   |kit.org                     |
                 CC|                            |tony at chromium.org




--- Comment #3 from Tony Chang (Google) <tony at chromium.org>  2010-01-12 23:13:11 PST ---
What should happen is that we have a list item with a horizontal rule in it
that gets indented to be a 2 level deep list item.  The call to insert should
just indent the list item one level in.  Instead, it doesn't try to indent the
list item and gets confused and tries to put a blockquote around the HR.

It doesn't try to indent the list item because enclosingBlock(Node*) in
htmlediting.cpp can return the current element.  The FIXME on the function
says:

// FIXME: Pass a position to this function.  The enclosing block of [table, x]
for example, should be the 
// block that contains the table and not the table, and this function should be
the only one responsible for 
// knowing about these kinds of special cases.

I'm not sure how passing a Position into the function will fix this.  However,
I can work around this at the call site and call enclosingBlock a second time
if it returns the passed in Node.  Patch coming that demonstrates this
approach.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.