[Webkit-unassigned] [Bug 33558] [Android] JavaString uses JSC-specific types

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 12 16:42:45 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=33558


Steve Block <steveblock at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|webkit-unassigned at lists.web |steveblock at google.com
                   |kit.org                     |
  Attachment #46412|                            |review?
               Flag|                            |




--- Comment #1 from Steve Block <steveblock at google.com>  2010-01-12 16:42:44 PST ---
Created an attachment (id=46412)
 --> (https://bugs.webkit.org/attachment.cgi?id=46412)
Patch 1 for Bug 33558

This moves the JSC-specific implementation of JavaString to a private
implementation class. A later change will add the V8 equivalent. Also modifies
JavaField::name and JavaMethod::name to return const JavaString&, rather than
UString::Rep*, which is JSC-specific.

Note that JavaString retains one JSC-specific method, operator UString. This is
required for JSC only to allow UString::rep to be used to represent the
JavaString. To avoid this anomaly, we could move the entire JavaString class to
JSC and V8-specific files, but this means losing the sharing of code between
the two.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list