[Webkit-unassigned] [Bug 33533] window.onload never fires if page contains an <iframe> whose load is cancelled by returning null from resource load delegate's willSendRequest

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33533





--- Comment #8 from Adam Roben (aroben) <aroben at apple.com>  2010-01-12 16:18:27 PST ---
The following change seems to fix the bug and doesn't make any regression tests
fail. It seems right to me. Maybe I can get Anders or some similarly
loader-educated person to take a look.

@@ -412,16 +412,7 @@ Frame* FrameLoader::loadSubframe(HTMLFrameOwnerElement*
ownerElement, const KURL

     checkCallImplicitClose();

-    // In these cases, the synchronous load would have finished
-    // before we could connect the signals, so make sure to send the
-    // completed() signal for the child by hand
-    // FIXME: In this case the Frame will have finished loading before
-    // it's being added to the child list. It would be a good idea to
-    // create the child first, then invoke the loader separately.
-    if (url.isEmpty() || url == blankURL()) {
-        frame->loader()->completed();
-        frame->loader()->checkCompleted();
-    }
+    frame->loader()->checkCompleted();

     return frame.get();
 }

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.