[Webkit-unassigned] [Bug 32722] Allow Reserved Words in Property Accessors

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 12 13:26:53 PST 2010


--- Comment #22 from Patrick Mueller <pmuellr at yahoo.com>  2010-01-12 13:26:51 PST ---
(In reply to comment #21)
> > All these recent tests indicate: the new grammar is slower.  I assume I should
> > look for alternatives at this point?
> You could try making the tests larger, then using the --profiling and  --shark
> or --shark20 flags on run-sunspider to see if shows any unreasonably hot
> points?

Thanks for the pointers.  A little worried though - I really would need to diff
such a profile run against the current parser, because I'm looking for
hot-spots in the diffs.  And then I'm worried I may not be able to track such a
hot-spot back to the Grammar.y file.

I think what I'm going to do first is actually figure out more about how the
grammar actually works, and see if it can be systematically fixed.  For
example, I'm assuming now that there are more look ups for these "property"
accesses to see if the property is actually a reserved word, when in fact ...
it doesn't matter.  If it's an identifier, then it's legal, doesn't actually
matter if it's a reserved word or not.  Even worse, using reserved words as
property values is the exception rather than the rule, and we haven't even
benched using reserved words as properties yet!  Presumably, cooking thoughts
like into the grammar would result in a faster parser - less work to do at the
property parsing points.  Time to crack open "Bison for Dummies!"

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list