[Webkit-unassigned] [Bug 30552] [Symbian] Port ARM traditional JIT Trampolines to RVCT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30552


Pushparajan <vprajan at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vprajan at gmail.com




--- Comment #32 from Pushparajan <vprajan at gmail.com>  2010-01-12 01:56:12 PST ---
(In reply to comment #29)
> (In reply to comment #24)
> > > +        * JavaScriptCore.pri: Extra step to generate RVCT stubs. The 
> > > +        script generation intentionally executed all the time not just
> > > +        for RVCT targets.
> > 
> > Is the generation necessary for all platform? 
> 
> Loki, the easiest/safest way to create a Symbian build is to create the
> generated files on Linux and than use the Symbian environment only for
> compiling/linking. This assumes that generation is turned on not just for
> RVCT/Symbian builds, but for all Qt builds. I do not think this is a big
> overhead for non-RVCT builds.
> 
> Can you give us your feedback on the latest uploaded patch ? I think your input
> would help reviewers. Does the patch looks good to you now ?

using GNU m4 instead of custom perl scripts would be a good option.. I too
faced a similar issue and did something like this for RVCT compiler, 

>>>>>>>>>>>>>>>>>>>>>>>>>

m4_define(`DEFINE_STUB_FUNCTION', `
extern "C" { 
          $1 JITStubThunked_$2(STUB_ARGS_DECLARATION); 
}; 

__asm $1 JIT_STUB cti_$2(STUB_ARGS_DECLARATION) { 
    str lr, [sp, #0x1c]; 
    bl __cpp(JITStubThunked_$2);
    ldr lr, [sp, #0x1c];
    bx lr;
}

$1 JITStubThunked_$2(STUB_ARGS_DECLARATION)')

>>>>>>>>>>>>>>>>>>>>>>

After that, just ran m4 tool over the source code to get automatically expanded
macros. 

Just sharing here so since this fix looked simpler and effective.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.