[Webkit-unassigned] [Bug 33364] [Chromium] Should not select a word on right-click in editable text

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33364





--- Comment #7 from TAMURA, Kent <tkent at chromium.org>  2010-01-11 22:27:07 PST ---
I confirmed the current spell correction code assumed a misspelled word was
selected.

ExecuteItemCommand() in render_view_context_menu.cc:
    case IDC_SPELLCHECK_SUGGESTION_0:
    case IDC_SPELLCHECK_SUGGESTION_1:
    case IDC_SPELLCHECK_SUGGESTION_2:
    case IDC_SPELLCHECK_SUGGESTION_3:
    case IDC_SPELLCHECK_SUGGESTION_4:
      source_tab_contents_->render_view_host()->Replace(
          params_.dictionary_suggestions[id - IDC_SPELLCHECK_SUGGESTION_0]);
      break;

RenderView::OnReplace() is simply:
  webview()->focusedFrame()->replaceSelection(text);


However it seems not hard to change it so that replacing non-selected
misspelled word.
1. selectMisspelledWord() in ContextMenuClientImpl.cpp returns a word without
changing selection if there is no selection.
2. RenderView::OnReplace() replaces a word around the cursor with the specified
string if there is no existing selection. (If ViewMsg_Replace() is used by
other code, we should introduce new ViewMsg for this.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.