[Webkit-unassigned] [Bug 33188] ER: Need a way to know when FrameLoader is loading a URL based on user action

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33188





--- Comment #17 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2010-01-11 18:42:01 PST ---
(In reply to comment #16)
> (In reply to comment #12)
> > - Introduce new concept (FrameLoader::wasLoadedByUserGesture() or similar) with
> tests.
> Are you sure that using a flag on the FrameLoader is the right thing to do?
> Some of the pathways through FrameLoader to load a resource are asynchronous,
> so making sure that the flag is correct when the asynchronous callbacks in
> FrameLoader are executed would be tricky. That's why I proposed adding the flag
> to the ResourceRequest, so it can carry the flag with it as it moves through
> FrameLoader.

I am not sure.  Adding a flag was my initial thought, but I didn't have time to
investigate all of the various entry points into FrameLoader to make sure the
flag was always correct when checked.  I've since got pulled away to work on
other issues, so I probably won't get back to this very soon.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.