[Webkit-unassigned] [Bug 33492] [Chromium] Move getSessionStorageNamespace from WebKitClient to WebViewClient

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33492


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46308|review?                     |review-
               Flag|                            |




--- Comment #2 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-01-11 15:33:25 PST ---
(From update of attachment 46308)
> Index: WebCore/ChangeLog
...
> +        No new tests. (OOPS!)

^^^ need to delete this line

> Index: WebKit/chromium/public/WebKitClient.h
...
> +    // THIS IS DEPRICATED.  WebViewClient::getSessionStorageNamespace() is the new way to access this.

^^^ deprecated


> Index: WebKit/chromium/public/WebViewClient.h

> +    // Session Storage ------------------------------------------------------
> +
> +    // Get the session storage namespace associated with this WebView.
> +    virtual WebStorageNamespace* getSessionStorageNamespace() { return 0; }

why isn't this called createSessionStorageNamespace?  if the embedder owns the
returned
pointer, then you should just call this sessionStorageNamespace.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.