[Webkit-unassigned] [Bug 22384] svg <text> fails to update when setting x/y

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22384





--- Comment #15 from Nikolas Zimmermann <zimmermann at kde.org>  2010-01-11 11:07:09 PST ---
(In reply to comment #14)
> (From update of attachment 46289 [details])
> > +        Introduce JSSVGCustomListTemplate, refactoring the existing custom code for SVG POD type lists.
> 
> This is now spelled correctly, but doesn't reflect your patch :-)
Awww, fixed ;-)

> Ditto.
Ditto :-)

> I think the common term is "templatized".
Fixed,

> Seems like these functions don't need the JSPODListType template parameter.
True.

> If you remove the JSPODListType template parameter from finishSetter, I think
> the compiler will be able to deduce the other template parameter. (Ditto for
> finishSetterReadOnlyResult and finishGetter.)
Unfortunately that won't help still need to pass <PODType>. But it's better
than passing two arguments.

> You also don't need the "&" here to create the function pointer. (C++ allows
> omitting it.)
Again news to me :-)

Will fix before landing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.