[Webkit-unassigned] [Bug 33468] PluginView::m_mode not initialized when constructed with null PluginPackage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33468


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46281|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #5 from Darin Adler <darin at apple.com>  2010-01-11 09:35:06 PST ---
(From update of attachment 46281)
Another way to fix this is to get rid of m_mode and replace it with a function.

The value of m_mode never changes and so is always based on m_loadManually and
is used in only 3 places in the tree.

I'm especially mystified by the code in Qt's PluginView::setNPWindowIfNeeded
that checks for m_mode values other than NP_EMBED and NP_FULL. Seems clearly to
be dead code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.