[Webkit-unassigned] [Bug 33405] [OpenVG] Implement a basic GraphicsContext on top of a new PainterOpenVG class

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33405





--- Comment #5 from Jakob Petsovits <jpetsovits at rim.com>  2010-01-11 07:59:53 PST ---
> Is it realy neccessary to store the current fill color of the painter and reset
> is after the painting of the rect?

Well, given the absence of any specification/apidox for this method (and many
others in WebKit), it's not so easy to tell which of the two behaviors is
standard. I read the function signature "fillRect(rect, color)" as "fill this
rect with color, ignoring the current fill paint" which implies not changing
the paint state permanently.

The CG port does revert to the old fill color. The Qt port seems not to. Skia
does it differently, so it doesn't really apply there, but for all practical
purposes it also doesn't change state. So I guess you don't really see any
effects because WebKit drawing code doesn't rely a lot on the state, or doesn't
use that function very often. From a semantic point of view, I find it hard to
see that someone would specify a function like this with state modification
included, so my suspicion is that it's rather a bug in Cairo and Qt than in CG,
Skia and OpenVG.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.