[Webkit-unassigned] [Bug 33197] bugzilla-tool submit-patch mistakenly picks up bug URLs in non-ChangeLog files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33197





--- Comment #9 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2010-01-11 06:39:47 PST ---
(In reply to comment #7)
> (In reply to comment #6)
> > (From update of attachment 46247 [details] [details])
> > >          original_diff = tool.scm().diff_for_revision(revision)
> > > +        # FIXME: This is wrong because it picks up bug numbers outside of ChangeLogs
> > >          return parse_bug_id(original_diff)
> > 
> > Why wasn't this instance fixed at the same time?  At minimum, this should be
> > explained in the ChangeLog.
> 
> It's a different bug.  The problem is this code wants to grab the bug number
> for a specific revision, while the code I changed is grabbing it for the
> current diff.

That seems to me like it's the same bug on a different code path.  Since it's
not being fixed by a patch for this bug, please file a new bug for it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.