[Webkit-unassigned] [Bug 33418] [Qt] Custom select popups.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33418





--- Comment #21 from Simon Hausmann <hausmann at webkit.org>  2010-01-11 06:32:40 PST ---
(In reply to comment #13)
> Created an attachment (id=46209)
 --> (https://bugs.webkit.org/attachment.cgi?id=46209) [details]
> Custom popups, popup factories and usage example.

Some comments:

* I don't understand why we're adding a public exported class but a private API
to actually use it.

* I'm not particularly fond of the term QWebPopup. It suggests that this
relates to popup menus in web sites (sometimes also called dhtml menus). Just
brainstorming: How about QWebListSelectionDelegate (too long)?

* Public Qt classes usually don't have non-virtual protected methods, they
belong into the d-pointer.

* It appears the parent of the popup should be passed to the constructor and at
the time the factory is called. That would also reduce the number of virtual
functions one has to re-implement.

* Why is there a difference between show() and hide()? Why not capture the
delegation in one single function call? Something along the lines of

int selectedIndex = select(geometry, items, initialSelectedIndex);


I think a goal of this API should be that it requires minimal effort to
implement. If all it takes is one method call, then perhaps a better frame for
this would be a QWebUIDelegate of some sort, provided we can keep it easily and
conviently extensible.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.