[Webkit-unassigned] [Bug 33197] bugzilla-tool submit-patch mistakenly picks up bug URLs in non-ChangeLog files

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 10 21:53:23 PST 2010


--- Comment #7 from Adam Barth <abarth at webkit.org>  2010-01-10 21:53:23 PST ---
(In reply to comment #6)
> (From update of attachment 46247 [details])
> > +        Also, fixed a wide-spread typo.
> This should be a separate patch.  rs=me to fix the typo separately.


> >          original_diff = tool.scm().diff_for_revision(revision)
> > +        # FIXME: This is wrong because it picks up bug numbers outside of ChangeLogs
> >          return parse_bug_id(original_diff)
> Why wasn't this instance fixed at the same time?  At minimum, this should be
> explained in the ChangeLog.

It's a different bug.  The problem is this code wants to grab the bug number
for a specific revision, while the code I changed is grabbing it for the
current diff.

> Why didn't test results change in response to changing these text inputs? 

Apparently none of the tests actually cared what the values of the messages

> Shouldn't there be tests for grabbing the bug id from a local commit? 

None of the sites I changed affected that.  I'll be happy to add that test once
we fix that bug.  :)

> (Or to reverse the question, why change the URLs if test results didn't change?)

Because they were wrong.  The commit messages generated in those mocks were
treated has having one character per line.  I just changed the mocks to be
consistent and correct.

> r- to split the renames into a different patch and to answer the questions
> above.

Thank for the review!

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list