[Webkit-unassigned] [Bug 33089] Implement alphabetic CSS3 list-style-types

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33089


Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46019|0                           |1
        is obsolete|                            |




--- Comment #15 from Daniel Bates <dbates at webkit.org>  2010-01-10 21:06:12 PST ---
Created an attachment (id=46255)
 --> (https://bugs.webkit.org/attachment.cgi?id=46255)
Patch with test case

This patch includes all the changes suggested by Darin except for alphabetizing
the values in files css/CSSValueKeywords.in and
rendering/style/RenderStyleConstants.h.

I did not alphabetize these lists because there is some subtlety to the current
ordering with respect to how these values are used in the CSS parser. Among the
possible changes that would need to be made if we reorganize these lists is
line 2953 of CSSParser.cpp
<http://trac.webkit.org/browser/trunk/WebCore/css/CSSParser.cpp?rev=52784#L2953>.
In particular, it is unclear to me why we compute CSSValueDecimal -
CSSValueDisc. The comment above the line states "// Make the list style default
decimal", but I don't see how that corresponds to CSSValueDecimal -
CSSValueDisc. Notice, from the generated file CSSValueKeywords.h,
CSSValueDecimal - CSSValueDisc = 3. I'm not sure what to make of this.

I briefly looked at the method CSSPrimitiveValue::create(double value,
UnitTypes type), but I'm unclear what the purpose of value is (with respect to
the class in general - notice, it relates to m_value.num ). I mean, this method
looks like it uses value to look up the appropriate cached CSSPrimitiveValue
object (if one exists). Otherwise, it allocates a new CSSPrimitiveValue object
with value (which sets m_value.num). But, it's not clear to me what value
represents/means in general.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.