[Webkit-unassigned] [Bug 32372] Unify origin sandbox flag with m_noAccess in SecurityOrigin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32372





--- Comment #6 from Adam Barth <abarth at webkit.org>  2010-01-09 18:54:44 PST ---
(In reply to comment #3)
> Typo: "havine".

Fixed.

> This is a member function, and C++ does not have methods, so I suggest we call
> it a "function" in this comment.

Fixed all occurrences in this file.

> This can correctly handle tightening of sandbox flags, but not loosening of
> them.

I added a comment to the code explaining why the code is doing this.  There's a
bug here, but it's the opposite of what you think.  I'd like to fix that in the
"defensive initialization" bug, if that works for you.

> Why did you remove this comment. I assume you had a good reason, but I don't
> know what it is.

The comment wasn't really adding any value.  It's not really intrinsic in the
notion of these sandbox flags what the current API is for controlling them.

> I suggest removing the argument name here.

Fixed.

> Periods, not two.

Fixed all occurrences in this file.

> I think you mean "the latter" rather than "the later".

Fixed.

> Missing period after "unique".

Fixed.

> Why the bit fields here?

I've removed them.  I don't think they matter.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.